Need your opinion!

**keredor** · 10-08-2012,03:55 PM

Heys guys, bit of a funny one here. im just starting out on making a script. I have it at a stage where it should be working in-game, but its not. infact nothing happens at all. If anyone has any ideas i would love to hear them.

Code:

 #include <natives.h>
#include <common.h>
#include <strings.h>
#include <types.h>
#include <consts.h>

#include "settings.c"


float x1, y1, z1;
Ped carped;
Vehicle pedcar, mycar;
int carmake;
bool Exist=0;
Group mygroup;


void findme(void)
    {
    if (IS_CHAR_IN_ANY_CAR(GetPlayerPed()))
    {
    GET_CAR_CHAR_IS_USING(GetPlayerPed(), &mycar);
    GET_CAR_MODEL(mycar, &carmake);
    GET_CHAR_COORDINATES(GetPlayerPed(), &x1, &y1, &z1);
    }
    }

void CreateGroup(void)
{
	if(Exist==0)
	{
	GET_PLAYER_GROUP(GetPlayerIndex(), &mygroup);
	if(!DOES_GROUP_EXIST(mygroup))
	{
		CREATE_GROUP(0, mygroup, true);
		SET_GROUP_LEADER(mygroup, GetPlayerPed());
		SET_GROUP_SEPARATION_RANGE(mygroup, 9999.9);
        SET_PLAYER_GROUP_TO_FOLLOW_ALWAYS(GetPlayerPed());
        SET_GROUP_FOLLOW_STATUS(mygroup,1);
        SET_GROUP_FORMATION(mygroup,3);
        SET_GROUP_FORMATION_SPACING(mygroup, 5);
		Exist=1;
	}
	}
}

void carprefs(void)
{
    LOCK_CAR_DOORS(carmake,4);
    SET_CAR_CAN_BE_DAMAGED(carmake, 0);
    SET_CAR_CAN_BE_VISIBLY_DAMAGED(carmake, 0);
    SET_CAN_BURST_CAR_TYRES(carmake, 0);
    SET_CAR_ALWAYS_CREATE_SKIDS(carmake, 1);
}

void pedprefs(void)
{
    SET_GROUP_MEMBER(mygroup, carped);
    SET_GROUP_CHAR_DUCKS_WHEN_AIMED_AT(carped, false);
	SET_CHAR_NEVER_LEAVES_GROUP(carped, true);
	SET_CHAR_ACCURACY(carped, 100);
	SET_CHAR_CAN_BE_SHOT_IN_VEHICLE(carped, false);
	SET_CHAR_WILL_DO_DRIVEBYS(carped, true);
	SET_CHAR_WILL_MOVE_WHEN_INJURED(carped, true);
	SET_CHAR_WILL_USE_COVER(carped, false);
    SET_CHAR_BULLETPROOF_VEST(carped, true);
	SET_CHAR_PROVIDE_COVERING_FIRE(carped, true);
	SET_CHAR_WILL_USE_CARS_IN_COMBAT(carped, true);
	SET_PED_DONT_DO_EVASIVE_DIVES(carped, true);
	SET_CURRENT_CHAR_WEAPON(carped, WEAPON_MP5, true);
}


void createpeds(void)
    {
    findme();
    CreateGroup();
        GET_CHAR_COORDINATES(GetPlayerPed(), &x1, &y1, &z1);
        REQUEST_MODEL(carmake);
        while (!HAS_MODEL_LOADED(carmake)) WAIT(0);
        CREATE_CAR(carmake, x1+3.0f, y1, z1, &carmake, 1);
           REQUEST_MODEL(MODEL_M_M_FATCOP_01);
           while (!HAS_MODEL_LOADED(MODEL_M_M_FATCOP_01)) WAIT(0);
           CREATE_CHAR_INSIDE_CAR(carmake, 16, MODEL_M_M_FATCOP_01, &carped);
        carprefs();
        pedprefs();
    }

void pedspawner(void)
 {
    if(IS_BUTTON_JUST_PRESSED(0, DPAD_RIGHT))
     {
         createpeds();
     }
else if((IS_BUTTON_PRESSED(0, R1))  &&  (DOES_CHAR_EXIST,carped))
     {
         FIRE_PED_WEAPON(carped,0, 0, 0);
     }
 }


void main(void)
  {
    THIS_SCRIPT_IS_SAFE_FOR_NETWORK_GAME();
    pedspawner();
    WAIT(0);
  }

**HuN** · 10-08-2012,04:47 PM

Originally Posted by keredor

Heys guys, bit of a funny one here. im just starting out on making a script. I have it at a stage where it should be working in-game, but its not. infact nothing happens at all. If anyone has any ideas i would love to hear them.

Code:

 #include <natives.h>
#include <common.h>
#include <strings.h>
#include <types.h>
#include <consts.h>

#include "settings.c"


float x1, y1, z1;
Ped carped;
Vehicle pedcar, mycar;
int carmake;
bool Exist=0;
Group mygroup;


void findme(void)
    {
    if (IS_CHAR_IN_ANY_CAR(GetPlayerPed()))
    {
    GET_CAR_CHAR_IS_USING(GetPlayerPed(), &mycar);
    GET_CAR_MODEL(mycar, &carmake);
    GET_CHAR_COORDINATES(GetPlayerPed(), &x1, &y1, &z1);
    }
    }

void CreateGroup(void)
{
	if(Exist==0)
	{
	GET_PLAYER_GROUP(GetPlayerIndex(), &mygroup);
	if(!DOES_GROUP_EXIST(mygroup))
	{
		CREATE_GROUP(0, mygroup, true);
		SET_GROUP_LEADER(mygroup, GetPlayerPed());
		SET_GROUP_SEPARATION_RANGE(mygroup, 9999.9);
        SET_PLAYER_GROUP_TO_FOLLOW_ALWAYS(GetPlayerPed());
        SET_GROUP_FOLLOW_STATUS(mygroup,1);
        SET_GROUP_FORMATION(mygroup,3);
        SET_GROUP_FORMATION_SPACING(mygroup, 5);
		Exist=1;
	}
	}
}

void carprefs(void)
{
    LOCK_CAR_DOORS(carmake,4);
    SET_CAR_CAN_BE_DAMAGED(carmake, 0);
    SET_CAR_CAN_BE_VISIBLY_DAMAGED(carmake, 0);
    SET_CAN_BURST_CAR_TYRES(carmake, 0);
    SET_CAR_ALWAYS_CREATE_SKIDS(carmake, 1);
}

void pedprefs(void)
{
    SET_GROUP_MEMBER(mygroup, carped);
    SET_GROUP_CHAR_DUCKS_WHEN_AIMED_AT(carped, false);
	SET_CHAR_NEVER_LEAVES_GROUP(carped, true);
	SET_CHAR_ACCURACY(carped, 100);
	SET_CHAR_CAN_BE_SHOT_IN_VEHICLE(carped, false);
	SET_CHAR_WILL_DO_DRIVEBYS(carped, true);
	SET_CHAR_WILL_MOVE_WHEN_INJURED(carped, true);
	SET_CHAR_WILL_USE_COVER(carped, false);
    SET_CHAR_BULLETPROOF_VEST(carped, true);
	SET_CHAR_PROVIDE_COVERING_FIRE(carped, true);
	SET_CHAR_WILL_USE_CARS_IN_COMBAT(carped, true);
	SET_PED_DONT_DO_EVASIVE_DIVES(carped, true);
	SET_CURRENT_CHAR_WEAPON(carped, WEAPON_MP5, true);
}


void createpeds(void)
    {
    findme();
    CreateGroup();
        GET_CHAR_COORDINATES(GetPlayerPed(), &x1, &y1, &z1);
        REQUEST_MODEL(carmake);
        while (!HAS_MODEL_LOADED(carmake)) WAIT(0);
        CREATE_CAR(carmake, x1+3.0f, y1, z1, &carmake, 1);
           REQUEST_MODEL(MODEL_M_M_FATCOP_01);
           while (!HAS_MODEL_LOADED(MODEL_M_M_FATCOP_01)) WAIT(0);
           CREATE_CHAR_INSIDE_CAR(carmake, 16, MODEL_M_M_FATCOP_01, &carped);
        carprefs();
        pedprefs();
    }

void pedspawner(void)
 {
    if(IS_BUTTON_JUST_PRESSED(0, DPAD_RIGHT))
     {
         createpeds();
     }
else if((IS_BUTTON_PRESSED(0, R1))  &&  (DOES_CHAR_EXIST,carped))
     {
         FIRE_PED_WEAPON(carped,0, 0, 0);
     }
 }


void main(void)
  {
    THIS_SCRIPT_IS_SAFE_FOR_NETWORK_GAME();
    pedspawner();
    WAIT(0);
  }

try this in " main" :

Code:

 
void main(void)
{	
	THIS_SCRIPT_IS_SAFE_FOR_NETWORK_GAME();
	while (TRUE)
	{
		WAIT(0);
		 pedspawner();
	}
}

**keredor** · 10-08-2012,04:53 PM

Originally Posted by HuN

try this in " main" :

Code:

 
void main(void)
{	
	THIS_SCRIPT_IS_SAFE_FOR_NETWORK_GAME();
	while (TRUE)
	{
		WAIT(0);
		 pedspawner();
	}
}

Thank's HuN. Ill test it out later tonight and let you know if it worked out.

**HuN** · 10-08-2012,05:06 PM

good luck !

btw , in " main " example here ... anything above " while ( true ) " is read once by engine , everything under " wait(0); " is read continiously (loop)

**keredor** · 10-08-2012,05:42 PM

Originally Posted by HuN

good luck !

btw , in " main " example here ... anything above " while ( true ) " is read once by engine , everything under " wait(0); " is read continiously (loop)

Ok, that's cool. It then makes sense as to why nothing was happening in game.

**zorg93** · 10-08-2012,06:35 PM

lol, missed while loop was the error, hahaha. your getting abit slack keredor :P

**keredor** · 10-08-2012,07:38 PM

Originally Posted by zorg93

lol, missed while loop was the error, hahaha. your getting abit slack keredor :P

LMAO. a very low standard from me. because i worked alot with alex's menu lately, have not been creating a main function. lesson learned the hard way!

**HuN** · 10-09-2012,10:49 AM

Originally Posted by keredor

LMAO. a very low standard from me. because i worked alot with alex's menu lately, have not been creating a main function. lesson learned the hard way!

simple errors that are not detected by compiler , can sometimes be the most hard to find ... for they can be too obvious for your brain to even consider them .

btw , when i replied , i didnt remembered you released a menu and that you knew coding ! sorry if my reply offended you in any way ( just in case )

**keredor** · 10-09-2012,11:00 AM

Originally Posted by HuN

simple errors that are not detected by compiler , can sometimes be the most hard to find ... for they can be too obvious for your brain to even consider them .

btw , when i replied , i didnt remembered you released a menu and that you knew coding ! sorry if my reply offended you in any way ( just in case )

No man you most certainly did not offend me!It was just the exact piece of advice i was after.I knew I was missing something and just couldn't put my finger on it.So thank you for helping out. Also I know there is not much point in saying this, but it worked lastnight!

**HuN** · 10-09-2012,11:11 AM

Originally Posted by keredor

No man you most certainly did not offend me!It was just the exact piece of advice i was after.I knew I was missing something and just couldn't put my finger on it.So thank you for helping out. Also I know there is not much point in saying this, but it worked lastnight!

i was playing safe here ... english aint my 1st language , so i rather say im sorry when im a little confused .

im glad i could help

User Tag List

Thread: Need your opinion!

Tweet

LinkBack

Thread Tools

Display


	Would you like to get all the new info from PSX-Scene in your email each day? Subscribe to our Daily Digest! Want to learn more about the team keeping you up to date with the latest scene news? Read about them now! Check out our Developer bios, too!