To the guys from Codemasters-project

[Vampmaster]

I'll post this in the board for the site when the english version's board is up and running, but for now I'll just disscuss it here.

I've been working on a converter based on the MAXcrypt except it converts MAX codes to and from other cheat device formats. I've been doing it my myself so far and I have a good idea how it's going to work, but I was wondering if any of you guys know C++ and would be able to help me with finding the errors. In the mind (AFAIK most of you are also part of ITM) has produced quite a few converters and stuff so I was hoping you'd be able to help me with this.

If I can say "it crashes when I do this" I should be able to fix the errors, but I can't pinpoint which part of the program is causing it to crash. I've been posting updates in the following thread:

http://www.ps2newz.net/forums/showth...threadid=21955

I also tried to submit something about it in the codemasters project news section but it didn't show up even though I logged in, pressed F5 and went to the ad artical section etc.

[Pyriel]

I'll lend a hand.

[pzxzp]

Yeah!!! good luck! you have my support!

[KRISHNAMURTI]

ucf say he is going to help you but he can't write some kind of problem with the site?
he can get Pm's but not write nothing back in the site so can you tell Gmo vampmaster?

[KRISHNAMURTI]

hey he dont know what is happening weird Is some can help him?

[Vampmaster]

I 've got a little closer and found the method that the problem was in and made it crash less, but it doesn't stop it from crashing completely. I think it has something to do with how it adds the new line after every code. I've put comments in the part that it seems to be in. The method causing the problems is byteHex() in the hexbyte file. I've commented in two test codes at the bottom of that file. The longer one usually works but the short one doesn't, especially if I take out the if noOfcodes<codeCount statement in bytehex(). If I leave that line in and I have for example two five line codes seperated with an empty line, it can work fine the first few times I press the button, but then crash after that.

Here are the files:

http://pillarsofnosgoth.legacyofkain.net/TRANScrypt.ZIP

I had to convert the MAXcrypt and the TRANScrypt so it uses a win32 API GUI so that I'd be able to compile it with Dev-C++. I bought Visual C++ .NET and it arrived today so I should be able to use either the win32 API GUI or the .res file that came with the MAXcrypt.

EDIT: The calls to ar2Encrypt() can be commented out while you're testing for errors and there's a method I was going to make into the one for encrypt, but I ended up just using it to get the return values for other methods. If the calls to that method in the CR1 file aren't commented out and the output text area is given "inputC" instead of "outputC" then it will show you the number that the methods return.

[Vampmaster]

Well I managed to get VC++.NET working. So at least I can write my program but the converter still crashes or shuts itself down.

[KRISHNAMURTI]

hey,Vamp so is goin Okay?..I dont know is you talk to
Silver sephiro?

[Vampmaster]

No, C++.NET is just something that turns the stuff I've typed into stuff that the computer can understand. (It does it better than the one I had and it can help me find where I'm going wrong.) The program itself still isn't working properly.

[Vampmaster]

More details. I'm getting assertion errors, but I don't know what that means and can't find them. They're somewhere in here, I think. (I made some changes to the one I linked to earlier. It hasn't improved.)

#include "global.h"

u8 emptyLine(HWND tArea, u16 index) {
u16 lnNumber = 1 + (u16) SendMessage( // Position of next line
(HWND) tArea,
(UINT) EM_LINEFROMCHAR,
(WPARAM) index,
(LPARAM) 0
);

u16 lnIndex = (u16) SendMessage(
(HWND) tArea,
(UINT) EM_LINEINDEX, // Gets 1st char of next line
(WPARAM) lnNumber,
(LPARAM) 0
);

u16 lnLength = (u16) SendMessage( // Length of next line
(HWND) tArea,
(UINT) EM_LINELENGTH,
(WPARAM) lnIndex,
(LPARAM) 0
);
char* line = new char[lnLength];
SendMessage( // Get the line itself
(HWND) tArea,
(UINT) EM_GETLINE,
(WPARAM) lnIndex,
(LPARAM) line
);
// if (lnIndex>strlen(inputC)) return TRUE;
for (u16 index3 = 0; index3<lnLength; index3++) {
if (!isspace(line[index3])) {
return FALSE; // Go through and check for nulls.
}
}
return TRUE;
}

long hexByte(HWND tArea) {
Code* currentCode = firstCode;
u8 currentByte = 0, firstC = TRUE;
u16 index = 0, bArrIndex = 0, thisLine = 0, codeSize = 0, codePos = 0;
withoutNulls = 0;
codeCount = 0;
while (isspace(inputC[index])) {index++;}
for (index; index<(strlen(inputC)); index++) {
if ((strlen(inputC) > 0) && (isalnum(inputC[index])) &&
(firstC)) { // Is there at least 1 char?
withoutNulls += 16; // Allocate a line
firstC = FALSE; // 1st char found
}
if ((strlen(inputC) > 1) && (index<(strlen(inputC))-1) &&
(inputC[index] == '\n') && (isalnum(inputC[index+1]))) {
// Is there a new line of Code?
// currentCode->size += 16;
withoutNulls += 16; // Allocate a new line
}
}
byteArray = new u8[withoutNulls>>1];
index=0;
while (isspace(inputC[index])) {index++;}
for (bArrIndex=0; bArrIndex<withoutNulls>>1 && index<strlen(inputC);) {

while (isspace(inputC[index]) && (inputC[index] != '\r')) {index++;}

if ((thisLine == 0) && (emptyLine(tArea, index))) {
codePos = bArrIndex - codeSize;
currentCode->theCode = new u8[codeSize];
memcpy(currentCode->theCode, &byteArray[codePos],
codeSize);
currentCode->size = codeSize;
currentCode->next = new Code();
currentCode = currentCode->next;
codeCount++;
codeSize = 0;
// while (isspace(inputC[index])) {index++;}
}
// Fill with zeros
if ((inputC[index] == '\r') & (thisLine > 0)) {
currentByte = 0;
}
else {
while (isspace(inputC[index])) {index++;}
if ((inputC[index] >= 'a') & (inputC[index] <= 'f')) {
currentByte = ((inputC[index] - 'a' + 10)<<4);
}
else if ((inputC[index] >= 'A') & (inputC[index] <= 'F')) {
currentByte = ((inputC[index] - 'A' + 10)<<4);
}
else if ((inputC[index] >= '0') & (inputC[index] <= '9')) {
currentByte = ((inputC[index] - '0')<<4);
}
else {
currentByte = 0;
}
index++;
}
// Fill with zeros
while (isspace(inputC[index]) && (inputC[index] != '\r')) {index++;}
if ((inputC[index] == '\r')) {
currentByte += 0;
}
else {
while (isspace(inputC[index])) {index++;}
if ((inputC[index] >= 'a') & (inputC[index] <= 'f')) {
currentByte += (inputC[index] - 'a' + 10);
}
else if ((inputC[index] >= 'A') & (inputC[index] <= 'F')) {
currentByte += (inputC[index] - 'A' + 10);
}
else if ((inputC[index] >= '0') & (inputC[index] <= '9')) {
currentByte += (inputC[index] - '0');
}
else {
currentByte += 0;
}
index++;
}
byteArray[bArrIndex] = currentByte;
if (thisLine < 7) {
thisLine++;
}
else {
thisLine = 0;
}
bArrIndex++;
codeSize++;
}

while (isspace(inputC[index]) && (inputC[index] != '\r')) {index++;}
codePos = bArrIndex - codeSize;
currentCode->theCode = new u8[codeSize];
memcpy(currentCode->theCode, &byteArray[codePos],
codeSize);
currentCode->size = codeSize;
currentCode->next = new Code();
currentCode = currentCode->next;
codeSize = 0;

/*byteArray = new u8[8];
byteArray[0] = 0xBB;
byteArray[1] = 0xAA;
byteArray[2] = 0xAA;
byteArray[3] = 0xAA;
byteArray[4] = 0xFF;
byteArray[5] = 0xFF;
byteArray[6] = 0xFF;
byteArray[7] = 0xFF;
byteArray[8] = 0xDD;
byteArray[9] = 0xCC;
byteArray[10] = 0xCC;
byteArray[11] = 0xCC;
byteArray[12] = 0x22;
byteArray[13] = 0x22;
byteArray[14] = 0x22;
byteArray[15] = 0x22;
withoutNulls = 32;*/

return codeCount; // bArrIndex - codeSize;
}

long byteHex() {
Code* currentCode = firstCode;
outputC = new char[(19 * (withoutNulls>>4)) + ((2 + codeCount)<<1)];
u8 char0 = 0, char1 = 0, char2 = 0; // char1 and 2 are first and last 4 bits
u32 index2 = 0, noOfCodes = 0;
/*for (; currentCode->next; currentCode = currentCode->next) {
for (u32 index = 0; index < (currentCode->size); index += lineLength) {
// currentCode->size was withoutNulls>>1
for (u32 charNo = 0; charNo < lineLength; charNo++) {
char0 = currentCode->theCode[index + charNo];
char1 = char0 >> 4;
char2 = char0 &= 0x0F;
outputC[index2] = hexValues[char1];
index2++;
outputC[index2] = hexValues[char2];
index2++;
if (charNo == 3) {
outputC[index2] = ' ';
index2++;
}
if (charNo == 7) {
outputC[index2] = '\r';
index2++;
outputC[index2] = '\n';
index2++;
}
} // End of this line
} // End of this code
if (noOfCodes<codeCount) { // Seems to reduce number of crashes
// Still crashes it occasionally
outputC[index2] = '\r';
index2++;
outputC[index2] = '\n';
index2++;
}
noOfCodes++;
}*/
outputC[(19 * (withoutNulls>>4)) + ((2 + codeCount)<<1)] = '\0';
return noOfCodes;
}