The LED Thread

Printable View

Show 50 post(s) from this thread on one page

10-16-2010, 04:13 PM
DJLO

Quote:

Originally Posted by subcon959

Thanks for that matey, any chance you could do them for kakaroto v3 instead of hermes?
Cheers

EDIT: Well I had a go at doing it myself. It was surprisingly easy to setup the git/winavr stuff. I managed to get a working hex out of it but the green led stays on so I must've done something wrong inserting the above code.

Well here's the thing. I think the KaKaRoTo version shuts down the 2nd led after 10 seconds (i mentioned this post to him). On my blackcat the blue LED shuts off and the red stays on.

Problem is I have no idea where in the code he put that in there.

I was just using a search for // done in hermes but the psgroove.c from KaKaRoTo is totally different.

I'm at my upper end of coding knowledge with this one, i'd love to sit back and let someone else drive this and explain how in his code it's done and how we can increase the value to >10 seconds
10-16-2010, 04:17 PM
Yngwiedis

1 Attachment(s)

Can someone help with a creation of LEDs.h file ?

I use a udip board which have double LEDs and 4 different revisions.
Until now all of us with udip boards we use a modified version of psgroove.c (attached) because double LEDs are not working with the LUFA.

So now we need a new modified psgroove.c which can we use with KaKaRoTo fork or a working LEDs.h file.

So is there someone who can help with that ?
10-16-2010, 04:26 PM
JonahUK

Quote:

Originally Posted by DJLO

Well here's the thing. I think the KaKaRoTo version shuts down the 2nd led after 10 seconds (i mentioned this post to him). On my blackcat the blue LED shuts off and the red stays on.

Problem is I have no idea where in the code he put that in there.

I was just using a search for // done in hermes but the psgroove.c from KaKaRoTo is totally different.

I'm at my upper end of coding knowledge with this one, i'd love to sit back and let someone else drive this and explain how in his code it's done and how we can increase the value to >10 seconds

Noticed he is using expire_led = 10; after each connect which *may* be the code you are looking for, but I can't remeber if this was already part of the psgroove code.
10-16-2010, 04:36 PM
JonahUK

Quote:

Originally Posted by Yngwiedis

Can someone help with a creation of LEDs.h file ?

I use a udip board which have double LEDs and 4 different revisions.
Until now all of us with udip boards we use a modified version of psgroove.c (attached) because double LEDs are not working with the LUFA.

So now we need a new modified psgroove.c which can we use with KaKaRoTo fork or a working LEDs.h file.

So is there someone who can help with that ?

For those that don't know, it's an atmega32u2 with 8mhz clock.

These are the led define statements:-

UDIP1b - Dual G/R
#define led_init() (DDRB = (1<<6)|(1<<5), DDRD = (1<<5)|(1<<4))
#define led_red_on() (PORTB |= (1<<5), PORTB &= ~(1<<6))
#define led_red_off() (PORTB &= ~(1<<5), PORTB &= ~(1<<6))
#define led_green_on() (PORTB |= (1<<6), PORTB &= ~(1<<5))
#define led_green_off() (PORTB &= ~(1<<6), PORTB &= ~(1<<5))
#define led_blue_on() (PORTD |= (1<<4), PORTD &= ~(1<<5))
#define led_blue_off() (PORTD &= ~(1<<4), PORTD &= ~(1<<5))

UDIP1c1 - Dual R/G
#define led_init() (DDRB = (1<<6)|(1<<5), DDRD = (1<<5)|(1<<4))
#define led_red_on() (PORTD |= (1<<5), PORTD &= ~(1<<4))
#define led_red_off() (PORTD &= ~(1<<5), PORTD &= ~(1<<4))
#define led_green_on() (PORTD |= (1<<4), PORTD &= ~(1<<5))
#define led_green_off() (PORTD &= ~(1<<4), PORTD &= ~(1<<5))
#define led_blue_on() (PORTB |= (1<<6), PORTB &= ~(1<<5))
#define led_blue_off() (PORTB &= ~(1<<6), PORTB &= ~(1<<5))

UDIP1c2 - R/G and B
#define led_init() (DDRB = (1<<6)|(1<<5), DDRD = (1<<5)|(1<<4))
#define led_red_on() (PORTD |= (1<<4), PORTD &= ~(1<<5))
#define led_red_off() (PORTD &= ~(1<<4), PORTD &= ~(1<<5))
#define led_green_on() (PORTD |= (1<<5), PORTD &= ~(1<<4))
#define led_green_off() (PORTD &= ~(1<<5), PORTD &= ~(1<<4))
#define led_blue_on() (PORTB |= (1<<5), PORTB &= ~(1<<6))
#define led_blue_off() (PORTB &= ~(1<<5), PORTB &= ~(1<<6))

UDIP1a - R/G and B
#define led_init() (DDRB |= (1<<7)|(1<<4), DDRC = (1<<6)|(1<<2))
#define led_green_on() (PORTC |= (1<<2), PORTB &= ~(1<<4))
#define led_green_off() (PORTC &= ~(1<<2), PORTB &= ~(1<<4))
#define led_red_on() (PORTB |= (1<<4), PORTC &= ~(1<<2))
#define led_red_off() (PORTB &= ~(1<<4), PORTC &= ~(1<<2))
#define led_blue_on() (PORTB |= (1<<7))
#define led_blue_off() (PORTB &= ~(1<<7))

RGB board
#define led_init() (DDRB |= (1<<6), DDRD |= (1<<3))
#define led_red_on() (PORTB |= (1<<6))
#define led_red_off() (PORTB &= ~(1<<6))
#define led_green_on() (PORTD |= (1<<1))
#define led_green_off() (PORTD &= ~(1<<1))
#define led_blue_on() (PORTD |= (1<<0))
#define led_blue_off() (PORTD &= ~(1<<0))

All of these statements are coded directly in the psgroove.c file attached above.

If someone more experienced with coding could take these values and generate led.h files for each revision that would be excellent.

I was looking at this myself but my laptop hd went down which contained all the files and compiling environment so I have spent most of the day getting the laptop back up and running to the point it was at before..... f***king nightmare to say the least!:mad:
10-16-2010, 05:41 PM
splinter182

here is a pdf with the pin out of the atmega32u2

i'll take a look at this later today, im at work atm...

also gotta figure out what this really means:

Code:

(DDRB = (1<<6)|(1<<5), DDRD = (1<<5)|(1<<4)) (PORTB |= (1<<5), PORTB &= ~(1<<6)) (PORTB &= ~(1<<5), PORTB &= ~(1<<6))

maybe PORTB &= ~(1<<5) means set portb's bit 5 to 1? idk
10-16-2010, 06:30 PM
JonahUK

Quote:

Originally Posted by splinter182

here is a pdf with the pin out of the atmega32u2

i'll take a look at this later today, im at work atm...

also gotta figure out what this really means:

Code:

(DDRB = (1<<6)|(1<<5), DDRD = (1<<5)|(1<<4)) (PORTB |= (1<<5), PORTB &= ~(1<<6)) (PORTB &= ~(1<<5), PORTB &= ~(1<<6))

maybe PORTB &= ~(1<<5) means set portb's bit 5 to 1? idk

That was what I was struggling with because usually it is one number but here we have two statements (6 & 5) for the same port.

At first I thought it might be that it's bi-colour led (Red/Green) so 6 was Red & 5 was Green.

But we also have two values for the single colour led (blue)...... (although some revision have bi-color on both ports)... so mayber it is that?

Please see this post here:-
http://psx-scene.com/forums/545861-post236.html

Udip stated that LUFA can't handle bi-color leds properly which is why they use the psgroove.c file to control the leds.

So, could we not treat the leds as single colour led instead (by passing one value only)? By doing that, LUFA would work with it shouldn't it?

The example above would become:-

Code:

/** LED mask for the first LED on the board. */ #define LEDS_LED1 (1 << 6) /** LED mask for the second LED on the board. */ #define LEDS_LED2 (1 << 5)

etc. etc. in led.h?

The main led would be portb and the second led portd.

Cheers,
JonahUK.
10-16-2010, 08:21 PM
splinter182

Quote:

Originally Posted by splinter182

here is a pdf with the pin out of the atmega32u2

Quoting myself lol did i say i was going to link a pdf :lol: http://www.atmel.com/dyn/resources/p...ts/doc7799.pdf

EDIT:

ok i figured something out

Code:

UDIP1b - Dual G/R #define led_init() (DDRB = (1<<6)|(1<<5), DDRD = (1<<5)|(1<<4)) #define led_red_on() (PORTB |= (1<<5), PORTB &= ~(1<<6)) #define led_red_off() (PORTB &= ~(1<<5), PORTB &= ~(1<<6)) #define led_green_on() (PORTB |= (1<<6), PORTB &= ~(1<<5)) #define led_green_off() (PORTB &= ~(1<<6), PORTB &= ~(1<<5)) #define led_blue_on() (PORTD |= (1<<4), PORTD &= ~(1<<5)) #define led_blue_off() (PORTD &= ~(1<<4), PORTD &= ~(1<<5))

here bit wise operations are being used, i kept thinking it was using primitive types...
lets take the first line:

Code:

#define led_init() (DDRB = (1<<6)|(1<<5), DDRD = (1<<5)|(1<<4))

this is initialazing the ports B and D to all 0s, the operations being used are:
(1<<6)|(1<<5) which means (1<<6) OR (1<<5) since the bits are set in different locations the result will be all 0s on all bits in both ports, same with (1<<5)|(1<<4). the OR explanations is more clear below

then we take:

Code:

#define led_red_on() (PORTB |= (1<<5), PORTB &= ~(1<<6))

when this is executed (PORTB |= (1<<5), PORTB &= ~(1<<6) and executed.

Code:

(PORTB |= (1<<5)

this operation takes the value of PORTB and does a bitwise OR (the | character) meaning it takes the value of PORTB (all zeros) and the value (1<<5) and does the OR operations which results in only bit 5 being set to 1.

here is another example:

PORTB 0000 0000
(1<<5) 0010 0000
OR 0010 0000

(this is read in pairs, top and bottom bit, so bit 0 or PORTB or bit 0 of (1<<5))
OR operation returns a 1 if any of the 2 bits being ORed is 1.

now the second part:

Code:

PORTB &= ~(1<<6)

i think this is there for the logic that only 1 led is on at any given time, so if you are turning on 1 led, you gotta turn off the other.
what this does is similar to above but is an AND operation and a negation on (1<<6)

PORTB 0010 0000 < after the first opertaion, led is on
~(1<<6) 1011 1111 < bits inverted from negation
AND 0010 0000 < this will essentially turn off any other led if it was on

notice if PORTB would have been 0100 0000(second led on) and ANDed with 1011 1111, it would have been changed to 0000 0000 because because no pair of bits contains a pair of 1s thus turning off the led that was originally on.

WOW i just figured out why im learning what im learning in my discrete math class in college.

hope this is clear enough.

now if you wanted to make led.h files all you gotta do is copy and paste that sections into a text file and name it led.h then include it in the psgroove.c code

Code:

#include <led.h> or #include "led.h"
10-16-2010, 10:19 PM
JonahUK

Quote:

Originally Posted by splinter182

hope this is clear enough

:wow:

Mate all of that went right over my head!!!!

I'm 41 years old and can't remember that far back to when I was in school :lol: (and I didn't pay that much attention to maths then!!)

I had NEVER looked at any code or compiled anything in my life before I JB'ed my PS3 but I can read and now I can compile packages and hex (about as far as my knowledge goes!!)

Thanks for your explanation and interpretation of the code anyway, don't understand any of it but thanks for taking the time to explain.

I'll carry on making changes to an existing led.h file until I get a working one, hopefully before I'm 42!!!!

Seriously though, thanks once again Splinter.

Cheers,
JonahUK.
10-16-2010, 10:27 PM
splinter182

Quote:

Originally Posted by JonahUK

:wow:

Mate all of that went right over my head!!!!

I'm 41 years old and can't remember that far back to when I was in school :lol: (and I didn't pay that much attention to maths then!!)

I had NEVER looked at any code or compiled anything in my life before I JB'ed my PS3 but I can read and now I can compile packages and hex (about as far as my knowledge goes!!)

Thanks for your explanation and interpretation of the code anyway, don't understand any of it but thanks for taking the time to explain.

I'll carry on making changes to an existing led.h file until I get a working one, hopefully before I'm 42!!!!

Seriously though, thanks once again Splinter.

Cheers,
JonahUK.

lol no a problem, i just hope someone reads it and goes "AAh thats what all that means" honestly everyone has a different way of coding the same thing, if it was me i would have gone the easy way and just set the specific ports to the required binary value, also i forgot to comment on your previous post:

Code:

/** LED mask for the first LED on the board. */ #define LEDS_LED1 (1 << 6) /** LED mask for the second LED on the board. */ #define LEDS_LED2 (1 << 5)

this should actually read:

Code:

/** LED mask for the first LED on the board. */ #define LEDS_LED1 (PORTB=(1 << 6)) /** LED mask for the second LED on the board. */ #define LEDS_LED2 (PORTD=(1 << 5))

in this case you are ignoring the original value of PORTB and PORTD and setting them to whatever you want. This would be the easier to read way.

but you really gotta make sure you check where your led are wired to the chip, on my previous post i linked a pdf with the pin out of the atmega32. im sure PORTB=(1 << 6) would refer to PB6. so i would check where the led are wired first before changing values.
10-16-2010, 10:52 PM
DJLO

Holy crap splinter182 that is one hell of an explanation. Sadly i'm somewhat in JonahUK's position, it's been years since i've been in university and done crazy math that makes your head twitch.

I am able to follow your logic however, i would not be able to know where to begin to write a new file.

Would you be so kind as to explain something to us :

KaKaRoTo's code, has the LED power off after a short time (i think 10 seconds) for most boards, i know for certain it does it on the blackcat on all his latest updates.

What i would like to know is where the code that shows the delay of the led so i can increase it or tinker with it. I need a little push in the right direction.

I assume if you wanted to get creative you could have the LED's do the opposite colour scheme etc by switching the order of things around?

Show 50 post(s) from this thread on one page