OPL load games from usb subfolder

[saulogpc]

Hi,

I'd like to know if it's possible to edit the source of OPL, so that it can load games from usb subfolders.

I'm able to compile OPL by myself, so i just need some help to edit the right files.

Tried studying "usbsuport.c" but without success.

If anyone can help me, i'll be thankful.

[izdubar]

In usbsupport.c function usbFindPartition, change the 3 "mass" path there:

                snprintf(path, 64, "mass%d:%s", i, name);
		fd = fioOpen(path, O_RDONLY);

		if(fd >= 0) {
			snprintf(target, 8, "mass%d:", i);
			fioClose(fd);
			return 1;
		}
	}

	// default to first partition (for themes, ...)
	sprintf(target, "mass0:");

To:

                snprintf(path, 64, "mass%d:mysubfolder/%s", i, name);
		fd = fioOpen(path, O_RDONLY);

		if(fd >= 0) {
			snprintf(target, 8, "mass%d:mysubfolder/", i);
			fioClose(fd);
			return 1;
		}
	}

	// default to first partition (for themes, ...)
	sprintf(target, "mass0:mysubfolder/");

EDIT: oh wait, you must change the size of char buffer too. And that may have a lot repercussions.

In usbsupport.c

static char usbPrefix[8];

static char usbPrefix[32];

<- any value you need, accordingly to your path size

function usbLoadModules:

char path[32];
sprintf(path, "%sTHM/", usbPrefix);

In opl.c eventually, function tryAlternateDevice:

static int tryAlternateDevice(int types) {
	char path[64];

<- hold usbprefix content + "conf_opl.cfg"

And a lot more function in supportbase.c/system.c, every one that use the "usbprefix" as parameter...

sbIsSameSize(usbPrefix, usbULSizePrev);
sbReadList(&usbGames, usbPrefix, "/", &usbULSizePrev, &usbGameCount);
sbDelete(&usbGames, usbPrefix, "/", usbGameCount, id);
usbPrepareMcemu (vmc_path)
usbGetArt
sysCheckVMC(usbPrefix, "/", name, createSize);

Lots of changes in fact

[saulogpc]

Hi, izdubar.
Thank you so much, i'll make the changes when i get home.

[saulogpc]

Oh man, that doesn't work yet.
I made the changes and OPL is able to list the games in the subfolder PS2SMB of the NAS, when it's connected to the usb port. But when i start any game, it freezes on a white screen.
Could you, please, tell more about the size of char buffer?
Because i believe that is the point i'm making a mistake.
As you read, the folder i want is "mass0:PS2SMB/" but i don't know which size of buffer i use. Tried 64 for every function and the result was the white screen.
Thanks in advance.

[izdubar]

Send me your code so I can quick check.

Make a diff ("hg diff > mod.diff").

The size of the "char buffer" should just be enough to hol your whole path string. The widest case is probably when building the VMC path, for example:

mass0:PS2SMB/VMC/myVMCName.bin

That thing should fit into your char buffer. 64 should be enough as VMC name and Game name are limited to 32 char. Which mean you still have 32 char for "mass0:PS2SMB/..." (... = either "THM/", "VMC/VMCName", "ART/" ...)

But I hope you changed too the counter into the snprintf and other similar statement ? In my first post it was just a rapid explnation, but it was "incorrect". Here the good line:

snprintf(target, 8, "mass%d:", i);

->

snprintf(target, 14, "mass%d:PS2SMB/", i);


Btw you made me find a bug into the USB device code, but it was only happening when "fragmentation check" is enabled for file parts, which is probably not for most people as it is failing somewhere else anyway

[saulogpc]

Sorry, i don't know what "make a diff" means , so i will post the lines i edited here.
in usbsupport.c:

static char usbPrefix[32];

int usbFindPartition(char *target, char *name) {
	int i, fd;
	char path[64];

	for(i=0; i<5; i++) {
		snprintf(path, 64, "mass%d:PS2SMB/%s", i, name);
		fd = fioOpen(path, O_RDONLY);

		if(fd >= 0) {
			snprintf(target, 14, "mass%d:PS2SMB/", i);
			fioClose(fd);
			return 1;
		}
	}

	// default to first partition (for themes, ...)
	sprintf(target, "mass0:PS2SMB/");
	return 0;
}

// update Themes
	usbFindPartition(usbPrefix, "ul.cfg");
	char path[64];

I didn't edit the other files, because you told me "64" is enough in my case, and this is the default i found in that files.

The first time i edited, i used "32" in snprintf, but using "14" OPL returns me the same white screen after trying to load a game.

I can't understand why that doesn't work, because if OPL is able to list the games, i think it's accessing the subfolder "PS2SMB".

I also tried using a pen drive instead of the NAS, but i got the same result

Any idea?

[saulogpc]

Hey izdubar, thanks for helping me, but i think i don't have enough knowledge to get OPL to work the way i want.
Tried different values and a short path like "P/" instead of "PS2SMB/" but i always get the same result!
Is there any other instruction you can give me?
Bye

[izdubar]

In revision 507:

You can now configure an USB prefix folder. This is useful for people wanting to use the same external USB device either connected on their NAS and accessed through SMB, or directly (in traveler mode) to the PS2.

Usually NAS don't allow to share the "root" of the device, so you have to put your games into, let's say a "PS2SMB" folder.

When using this same device in USB mode, simply enter "PS2SMB" as USB prefix and your gone.

(The prefix is limited to 32 characters)

EDIT: It doesn't work (except in GUi) ... I know why however and will fix it next week

[saulogpc]

Thank you so much izdubar.
That's what i've been trying to do, but of course, your knowledge is much bigger than mine!

Thaks again

Bye

[izdubar]

It works now in revision 509.

Please check and report me if something is wrong.